Codestin Search App

alexislefebvre · 2018-12-09T17:05:49Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#28874, replaces #28933
License	MIT
Doc PR	TODO, requires symfony/symfony-docs#9476

Fetch data with the MetadataStore from #26092 in order to add colors to the dumps.

Example of configuration:

            transitions:
                submit:
                    from: start
                    to: travis
                    metadata:
                        title: transition submit title
                        dump_style:
                            label: 'My custom label'
                            arrow_color: '#0088FF'
                            label_color: 'Red'

This code was developed as a bundle, examples can be found on its repository: https://github.com/alexislefebvre/SymfonyWorkflowStyleBundle

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

lyrixx

I did not tested it, but It's a very good start

src/Symfony/Component/Workflow/Dumper/GraphvizDumper.php

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/workflows.php

alexislefebvre · 2018-12-13T22:26:46Z

The last two examples on this page shows the dot format, with multiple_state, transitions are displayed as square instead of arrows with texts.

So the option background_color is used instead of arrow_color because it's meaningless in this context. I still have to find a limited number of parameters that would allow styling states and transitions with state machines and workflows.

alexislefebvre · 2018-12-30T16:34:18Z

Can someone please remove the Deprecation tag? I forgot to change the value when creating the PR.

src/Symfony/Component/Workflow/CHANGELOG.md

nicolas-grekas · 2019-01-25T11:07:52Z

rebase needed due to short arrays.

alexislefebvre · 2019-02-05T13:57:16Z

Thanks for hint, the PR has been rebased.

fabpot · 2019-03-04T07:31:43Z

@lyrixx I think we need your help to move forward here.

lyrixx

👍

lyrixx · 2019-03-13T16:37:16Z

Thanks @alexislefebvre . This is very Good. Could you rebase before the merge ? (I think this will conflict with #30468 but I will take care of it).

Could someone review English textes (PHP Doc, Changelog)? 🙏 Thanks

alexislefebvre · 2019-03-13T22:00:22Z

Rebase done. ✔️

Thanks for the follow-up.

src/Symfony/Component/Workflow/CHANGELOG.md

fabpot · 2019-03-19T05:10:38Z

Thank you @alexislefebvre.

This PR was squashed before being merged into the 4.3-dev branch (closes #29538). Discussion ---------- [Workflow] Add colors to workflow dumps Fixes #28874 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28874, replaces #28933 | License | MIT | Doc PR | TODO, requires symfony/symfony-docs#9476 Fetch data with the `MetadataStore` from #26092 in order to add colors to the dumps. Example of configuration: ```yaml transitions: submit: from: start to: travis metadata: title: transition submit title dump_style: label: 'My custom label' arrow_color: '#0088FF' label_color: 'Red' ``` This code was developed as a bundle, examples can be found on its repository: https://github.com/alexislefebvre/SymfonyWorkflowStyleBundle Commits ------- 60ad109 [Workflow] Add colors to workflow dumps

…n (alexislefebvre) This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead (closes #32419). Discussion ---------- [Workflow] Add missing test for workflow dump description | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR add a test for a feature added in #29538 but missed a test. Commits ------- 0c326d0 Add missing test for workflow dump description

…alexislefebvre) This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] Explain how to style a workflow dump Fixes symfony#11675 Explain what was added in symfony/symfony#29538 TODO: - [x] Explain keys - [x] Add YAML format - [x] Add XML format - [x] Add PHP format Commits ------- e6c1992 Workflow: explain how to style a workflow dump

carsonbot added Status: Needs Review Feature Deprecation labels Dec 9, 2018

alexislefebvre changed the title ~~Add colors to workflow dumps~~ [Workflow] Add colors to workflow dumps Dec 9, 2018

alexislefebvre requested a review from lyrixx as a code owner December 9, 2018 17:11

nicolas-grekas added this to the next milestone Dec 9, 2018

javiereguiluz reviewed Dec 10, 2018

View reviewed changes

lyrixx reviewed Dec 10, 2018

View reviewed changes

src/Symfony/Component/Workflow/Dumper/GraphvizDumper.php Outdated Show resolved Hide resolved

ro0NL reviewed Dec 13, 2018

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/workflows.php Outdated Show resolved Hide resolved

Kronhyx approved these changes Dec 13, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Dec 13, 2018

alexislefebvre force-pushed the 28874-add-colors-to-workflow-dumps-2 branch from 03eb8fe to 31e9564 Compare December 15, 2018 00:53

alexislefebvre force-pushed the 28874-add-colors-to-workflow-dumps-2 branch from 31e9564 to 0b54bcb Compare December 30, 2018 16:36

javiereguiluz removed the Deprecation label Dec 30, 2018

noniagriconomie reviewed Jan 4, 2019

View reviewed changes

src/Symfony/Component/Workflow/CHANGELOG.md Outdated Show resolved Hide resolved

alexislefebvre force-pushed the 28874-add-colors-to-workflow-dumps-2 branch 6 times, most recently from 4698c38 to ebe5385 Compare February 5, 2019 00:57

lyrixx added the Workflow label Mar 13, 2019

lyrixx approved these changes Mar 13, 2019

View reviewed changes

alexislefebvre force-pushed the 28874-add-colors-to-workflow-dumps-2 branch from ebe5385 to e12babf Compare March 13, 2019 21:57

fabpot reviewed Mar 14, 2019

View reviewed changes

src/Symfony/Component/Workflow/CHANGELOG.md Outdated Show resolved Hide resolved

alexislefebvre force-pushed the 28874-add-colors-to-workflow-dumps-2 branch from 84a0553 to 4d313e5 Compare March 17, 2019 22:57

fabpot reviewed Mar 18, 2019

View reviewed changes

src/Symfony/Component/Workflow/CHANGELOG.md Show resolved Hide resolved

alexislefebvre force-pushed the 28874-add-colors-to-workflow-dumps-2 branch from 4d313e5 to 0a59b50 Compare March 18, 2019 21:30

fabpot approved these changes Mar 19, 2019

View reviewed changes

[Workflow] Add colors to workflow dumps

60ad109

fabpot force-pushed the 28874-add-colors-to-workflow-dumps-2 branch from 0a59b50 to 60ad109 Compare March 19, 2019 05:09

fabpot merged commit 60ad109 into symfony:master Mar 19, 2019

alexislefebvre deleted the 28874-add-colors-to-workflow-dumps-2 branch March 19, 2019 09:44

pbowyer mentioned this pull request Mar 23, 2019

[WiP] Document Workflow 4.3 changes symfony/symfony-docs#11211

Closed

3 tasks

nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

fabpot mentioned this pull request May 9, 2019

Release v4.3.0-BETA1 #31435

Merged

alexislefebvre mentioned this pull request Jun 5, 2019

Add docs for: [Workflow] Add colors to workflow dumps symfony/symfony-docs#11675

Closed

This was referenced Jul 7, 2019

[Workflow] Add missing test for workflow dump description #32419

Merged

[Workflow] Explain how to style a workflow dump symfony/symfony-docs#11907

Merged

gisostallenberg mentioned this pull request Dec 3, 2021

Workflow: Allow shapes to be set for places and transitions in dumpers #42620

Closed

alexislefebvre mentioned this pull request Dec 6, 2021

PlantUmlDumper: use str_starts_with() #44476

Closed

Uh oh!

Conversation

alexislefebvre commented Dec 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lyrixx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexislefebvre commented Dec 13, 2018

Uh oh!

alexislefebvre commented Dec 30, 2018

Uh oh!

Uh oh!

nicolas-grekas commented Jan 25, 2019

Uh oh!

alexislefebvre commented Feb 5, 2019

Uh oh!

fabpot commented Mar 4, 2019

Uh oh!

lyrixx left a comment

Choose a reason for hiding this comment

Uh oh!

lyrixx commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexislefebvre commented Mar 13, 2019

Uh oh!

Uh oh!

Uh oh!

fabpot commented Mar 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

alexislefebvre commented Dec 9, 2018 •

edited

Loading

lyrixx commented Mar 13, 2019 •

edited

Loading