[WiP] Document Workflow 4.3 changes #11211
Conversation
| @@ -80,7 +81,8 @@ like this: | |||
| <framework:workflow name="blog_publishing" type="workflow"> | |||
| <framework:audit-trail enabled="true"/> | |||
|
|
|||
| <framework:marking-store type="single_state"> | |||
| <framework:marking-store type="method"> | |||
| <framework:argument>false</framework:argument> | |||
| <framework:argument>currentPlace</framework:argument> | |||
| </framework:marking-store> | |||
|
|
|||
There was a problem hiding this comment.
I don't use XML config, can someone please provide the initial_places code for it.
There was a problem hiding this comment.
You can add many like this https://github.com/symfony/symfony/pull/30468/files#diff-0b1fae456d162214b077b0e1be47b40cR11.
There was a problem hiding this comment.
It would be nice to add it in the code doc.
Here is the final ref
There was a problem hiding this comment.
I believe I've done this correctly!
|
Hi |
There was a problem hiding this comment.
Thanks a lot for this PR.
This is an extract of the upcomming blog post:
I hope it will help you to update this PR.
A subject in a state machine can be in only one state whereas a subject in a
workflow can be in one or more places. From the first day of the Workflow
Component we let the user to be able to use a Workflow with a Single State
Marking Store. This was a mistake and this added some useless complexity.
As of now, If your subject can be in only on state: use a state machine. In that
case, the property (marking by default) will be a string. If the subject can
be in many places: use a workflow. In that case, the property will be an array.
| @@ -80,7 +81,8 @@ like this: | |||
| <framework:workflow name="blog_publishing" type="workflow"> | |||
| <framework:audit-trail enabled="true"/> | |||
|
|
|||
| <framework:marking-store type="single_state"> | |||
| <framework:marking-store type="method"> | |||
| <framework:argument>false</framework:argument> | |||
| <framework:argument>currentPlace</framework:argument> | |||
| </framework:marking-store> | |||
|
|
|||
There was a problem hiding this comment.
It would be nice to add it in the code doc.
Here is the final ref
Add missing `initial_places` to PHP configuration example. Someone needs to add it to the XML
d8a19c3 to
6c636cb
Compare
|
@pbowyer I regret to inform you that we've just merged a full reorganization of Workflow docs. This will introduce conflicts with your PR. I was postponing the merge, but it was only making things worse. If you don't want to rebase and fix the conflicts, I can create a new PR for you with your changes. I'm sorry. The main changes are:
|
| @@ -224,90 +227,11 @@ you can get the workflow by injecting the Workflow registry service:: | |||
| // ... if the transition is not allowed | |||
| } | |||
|
|
|||
| // Update the currentState on the post passing some contextual data | |||
There was a problem hiding this comment.
why do you remove this one?
|
@pbowyer is this PR still relevant now ? |
I don't know. There appears to be no coordination and people duplicating work in this repository, so I'm not committing any more time until that's clear. If you want to adopt this PR, fork it - you have my blessing. |
|
Ok |
|
@javiereguiluz i think we can close |
|
Because of the blessing of @pbowyer, I close this PR. @noniagriconomie please add the missing parts in a new PR. Anyway thanks for your work 👍🏻👍🏻 |
Document the changes in https://github.com/symfony/workflow/blob/master/CHANGELOG.md and https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#workflow:
Deprecate
multiple_stateandsingle_state. Done, but pending outcome of [RFC][DX][Workflow] Configuration of initial places and marking store symfony#30656initial_placeis deprecated in favour ofinitial_places. Done, but pending outcome of [RFC][DX][Workflow] Configuration of initial places and marking store symfony#30656Transition styling via metadata for dumps (see [Workflow] Add colors to workflow dumps symfony#29538 for details / examples)
WiP, more to be added. Community input/commits very welcome!