[Process] Adds usleep(1000) to ease CPU usage. #28940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miniyarov
commented
Oct 21, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | symfony/symfony-docs |
Nek-
approved these changes
Oct 22, 2018
miniyarov
commented
Oct 22, 2018
|
@nicolas-grekas added a break if process is not running |
| @@ -465,6 +465,11 @@ public function waitUntil(callable $callback) | |||
| $this->fallbackStatus['exitcode'] = (int) $data; | |||
| } | |||
| } | |||
| if ($this->isRunning()) { | |||
There was a problem hiding this comment.
what about writting in this way:
if ($wait && !$this->isRunning()) {
return false;
}
and make the function return a boolean (type-hint+return true at the end)
There was a problem hiding this comment.
Hmm this might change function's specification but doable
There was a problem hiding this comment.
The method is new so we can still do it. It'd make sense to me.
There was a problem hiding this comment.
Ok updated to return a boolean.
nicolas-grekas
approved these changes
Oct 22, 2018
| @@ -437,11 +437,13 @@ public function wait(callable $callback = null) | |||
| * It allows to have feedback from the independent process during execution. | |||
| * | |||
| * @param callable $callback | |||
| * | |||
| * @return bool | |||
There was a problem hiding this comment.
should be removed (same for $callback btw) as we remove docblocks that don't add anything on top of the PHP signature.
|
@nicolas-grekas Thanks to you too! |
dunglas
approved these changes
Oct 23, 2018
f23d687 to
9d1416a
Compare
javiereguiluz
approved these changes
Oct 23, 2018
|
Thank you @miniyarov. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 23, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes #28940). Discussion ---------- [Process] Adds usleep(1000) to ease CPU usage. | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs Commits ------- 9d1416a [Process] Adds usleep(1000) to ease CPU usage.
|
Could we have tests for this boolean return value ? |
Nek-
added a commit
to Nek-/symfony
that referenced
this pull request
Oct 29, 2018
The while condition was the opposite of the previous while. This was obviously leading to the death of this loop. Loop which was useful according to some people (see symfony#28940), so I just moved the code to the right position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.