[Security] Complain about an empty decision strategy #29981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44fb1ff to
35d3cc8
Compare
src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The actual issue is of course that the method names are not prefix-free. |
35d3cc8 to
ab12ca8
Compare
xabbuh
requested changes
Jan 26, 2019
Member
xabbuh
left a comment
There was a problem hiding this comment.
I think we should rather check that the passed value is not an empty string. The proposed solution has the drawback that it will fail again in the future if we introduce a doDecide() method for whatever reason.
ab12ca8 to
c537c85
Compare
c537c85 to
42e34f4
Compare
xabbuh
reviewed
Jan 28, 2019
src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Jan 28, 2019
src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
Outdated
Show resolved
Hide resolved
42e34f4 to
88502a5
Compare
88502a5 to
228329a
Compare
228329a to
21f73d2
Compare
21f73d2 to
3a22cad
Compare
Contributor
Author
|
I applied the requested changes; the label didn’t change, though. |
xabbuh
approved these changes
Feb 20, 2019
fabpot
approved these changes
Feb 21, 2019
Member
|
Thank you @corphi. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Security] Complain about an empty decision strategy | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When an empty string is passed (or objects with a similarly behaving `__toString()` method) to the constructor, the call to `decide` causes infinite recursion. Commits ------- 3a22cad Fix infinite recursion when passed an empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an empty string is passed (or objects with a similarly behaving
__toString()method) to the constructor, the call todecidecauses infinite recursion.