[HttpFoundation] Do not set a Transfer-Encoding header of chunked for streaming responses #3017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache expects the response to already be in chunked format in that case, which causes it to not deliver the streamed body. If no Content-Length is set on the response, web servers will automatically switch to chunked Transfer-Encoding, and handle the chunking for you. Nginx does not share the issue that apache has, but will add the Content- Length header too.
| @@ -33,7 +33,6 @@ public function testPrepareWith11Protocol() | |||
| $response->prepare($request); | |||
|
|
|||
| $this->assertEquals('1.1', $response->getProtocolVersion()); | |||
| $this->assertEquals('chunked', $response->headers->get('Transfer-Encoding')); | |||
There was a problem hiding this comment.
How about adding a negative test to avoid regressions and document why it's necessary, i.e. assertNotEquals(...)?
fabpot
added a commit
that referenced
this pull request
Jan 2, 2012
Commits ------- 7ae9348 [streaming] Document and test that Transfer-Encoding is absent 83c23ca [streaming] Do not set a Transfer-Encoding header of chunked Discussion ---------- [HttpFoundation] Do not set a Transfer-Encoding header of chunked for streaming responses Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes This is an adjustment to the streaming introduced in #2935. Apache expects the response to already be in chunked format when the Transfer-Encoding header is set to chunked, which causes it to not deliver the streamed body. If no Content-Length is set on the response (regardless of Transfer-Encoding), web servers will automatically switch to chunked Transfer-Encoding, and handle the chunking for you. I have tested this with Apache 2.2.2 and nginx 1.0.5. Testing with other webservers is appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
This is an adjustment to the streaming introduced in #2935.
Apache expects the response to already be in chunked format when the Transfer-Encoding header is set to chunked, which causes it to not deliver the streamed body.
If no Content-Length is set on the response (regardless of Transfer-Encoding), web servers will automatically switch to chunked Transfer-Encoding, and handle the chunking for you.
I have tested this with Apache 2.2.2 and nginx 1.0.5. Testing with other webservers is appreciated.