[VarDumper] Keep a ref to objects to ensure their handle cannot be reused while cloning #30350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used while cloning
fabpot
approved these changes
Feb 23, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 23, 2019
…annot be reused while cloning (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Keep a ref to objects to ensure their handle cannot be reused while cloning | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes the root issue that led to #30311 (comment) Commits ------- 29a0683 [VarDumper] Keep a ref to objects to ensure their handle cannot be reused while cloning
nicolas-grekas
added a commit
that referenced
this pull request
May 9, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [VarDumper] Remove unused code | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Not all was removed in the [PR](#52619). I did not remove [objects](#30350). It did look like unused code. Maybe some comment in code needed? Last uses of `Cookie` and `refs` were deleted [here](https://github.com/symfony/symfony/pull/41295/files#diff-27fadd95a89adb229b33890577a4495e15bdbc1b25f12c44f7afa8a12a00d37b). Last use of $[values](ff00f8f#diff-27fadd95a89adb229b33890577a4495e15bdbc1b25f12c44f7afa8a12a00d37bR100). Commits ------- fbc4c34 [VarDumper] Remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the root issue that led to #30311 (comment)