Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier][PropertyInfo][VarDumper] Remove unused code #52619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Remove unused code

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check fabbot, thanks

LGTM for the Notifier part

@fabpot fabpot force-pushed the feature/clean-unused-code-1 branch from 7074073 to c25ec99 Compare January 6, 2024 14:28
@fabpot
Copy link
Member

fabpot commented Jan 6, 2024

Thank you @alamirault.

@fabpot fabpot merged commit e3e518b into symfony:7.1 Jan 6, 2024
@alamirault alamirault deleted the feature/clean-unused-code-1 branch January 7, 2024 18:11
nicolas-grekas added a commit that referenced this pull request May 9, 2025
This PR was merged into the 7.3 branch.

Discussion
----------

[VarDumper] Remove unused code

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Not all was removed in the [PR](#52619).

I did not remove [objects](#30350). It did look like unused code. Maybe some comment in code needed?

Last uses of `Cookie` and `refs` were deleted [here](https://github.com/symfony/symfony/pull/41295/files#diff-27fadd95a89adb229b33890577a4495e15bdbc1b25f12c44f7afa8a12a00d37b).

Last use of $[values](ff00f8f#diff-27fadd95a89adb229b33890577a4495e15bdbc1b25f12c44f7afa8a12a00d37bR100).

Commits
-------

fbc4c34 [VarDumper] Remove unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants