[Messenger] Ensure that a TransportException is thrown on redis error #31298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Apr 27, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
bec60ac to
4d7f3c0
Compare
sroze
approved these changes
Apr 28, 2019
|
Thank you @chalasr. |
sroze
added a commit
that referenced
this pull request
Apr 28, 2019
…n redis error (chalasr) This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Ensure that a TransportException is thrown on redis error | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 1857395 [Messenger] Ensure that a TransportException is thrown on redis error
| } | ||
|
|
||
| public function setup(): void | ||
| { | ||
| $this->connection->xgroup('CREATE', $this->stream, $this->group, 0, true); | ||
| try { | ||
| $this->connection->xGroup('CREATE', $this->stream, $this->group, 0, true); |
There was a problem hiding this comment.
@chalasr Thanks for the fixes. Just to mention it here if mocking this with prophecy the function need to be called the lowercase version. See phpredis/phpredis#1489
fabpot
added a commit
that referenced
this pull request
May 2, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Lowercased method calls on \Redis | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31298 (comment) | License | MIT | Doc PR | n/a https://github.com/phpredis/phpredis/blob/64e71b5307b76f49a71ff43a09e984a80d9a7f12/php_redis.h#L231-L244 Commits ------- 2d41976 [Messenger] Lowercased method calls on \Redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.