-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Cache] Add Redis Sentinel support #31437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cache] Add Redis Sentinel support #31437
Conversation
444e0d9
to
0d1126f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, here are some comments
note that will be for 4.4: 4.3 is in maintenance mode already and accepts no new features.
fd178b4
to
6eb46d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(with minor comments)
6eb46d8
to
edf6170
Compare
edf6170
to
80e8b21
Compare
Thank you @StephenClouse. |
This PR was squashed before being merged into the 4.4-dev branch (closes #31437). Discussion ---------- [Cache] Add Redis Sentinel support | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11545 This change adds support for Redis Sentinel clusters to the Cache component Redis adapter. The DSN format is syntactically equivalent to cluster support, but adds a new parameter `redis_sentinel` that should be set to the sentinel service name. This support requires the use of predis as the underlying connection library. The redis extension does not support sentinel at this time. Commits ------- 80e8b21 [Cache] Add Redis Sentinel support
…nClouse) This PR was squashed before being merged into the master branch (closes symfony#11545). Discussion ---------- Document Redis Sentinel support for Cache Accompanying docs for symfony/symfony#31437 Commits ------- 4cfe39b Document Redis Sentinel support for Cache
This change adds support for Redis Sentinel clusters to the Cache component Redis adapter.
The DSN format is syntactically equivalent to cluster support, but adds a new parameter
redis_sentinel
that should be set to the sentinel service name.This support requires the use of predis as the underlying connection library. The redis extension does not support sentinel at this time.