Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] Add Redis Sentinel support #31437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StephenClouse
Copy link
Contributor

@StephenClouse StephenClouse commented May 9, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#11545

This change adds support for Redis Sentinel clusters to the Cache component Redis adapter.

The DSN format is syntactically equivalent to cluster support, but adds a new parameter redis_sentinel that should be set to the sentinel service name.

This support requires the use of predis as the underlying connection library. The redis extension does not support sentinel at this time.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, here are some comments
note that will be for 4.4: 4.3 is in maintenance mode already and accepts no new features.

@StephenClouse StephenClouse force-pushed the cache/redis-sentinel-support branch from fd178b4 to 6eb46d8 Compare May 9, 2019 19:11
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with minor comments)

@StephenClouse StephenClouse force-pushed the cache/redis-sentinel-support branch from 6eb46d8 to edf6170 Compare May 13, 2019 15:43
@nicolas-grekas nicolas-grekas changed the title Add Redis Sentinel support [Cache] Add Redis Sentinel support May 22, 2019
@nicolas-grekas nicolas-grekas force-pushed the cache/redis-sentinel-support branch from edf6170 to 80e8b21 Compare May 22, 2019 14:28
@nicolas-grekas
Copy link
Member

Thank you @StephenClouse.

@nicolas-grekas nicolas-grekas merged commit 80e8b21 into symfony:master May 22, 2019
nicolas-grekas added a commit that referenced this pull request May 22, 2019
This PR was squashed before being merged into the 4.4-dev branch (closes #31437).

Discussion
----------

[Cache] Add Redis Sentinel support

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#11545

This change adds support for Redis Sentinel clusters to the Cache component Redis adapter.

The DSN format is syntactically equivalent to cluster support, but adds a new parameter `redis_sentinel` that should be set to the sentinel service name.

This support requires the use of predis as the underlying connection library. The redis extension does not support sentinel at this time.

Commits
-------

80e8b21 [Cache] Add Redis Sentinel support
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request May 28, 2019
…nClouse)

This PR was squashed before being merged into the master branch (closes symfony#11545).

Discussion
----------

Document Redis Sentinel support for Cache

Accompanying docs for symfony/symfony#31437

Commits
-------

4cfe39b Document Redis Sentinel support for Cache
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants