[PhpUnitBridge] More accurate grouping #31730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8193095 to
38f3621
Compare
7 tasks
|
Hi there, it seems better to me :) FYI using Symfony 4.3.0-beta1 (without the Twig fixes in Pre-patch: Post-patch: |
a2a7612 to
0febb03
Compare
116907f to
d67f50c
Compare
greg0ire
commented
May 30, 2019
| @@ -18,6 +18,15 @@ | |||
| */ | |||
| class Deprecation | |||
| { | |||
| private const PATH_TYPE_VENDOR = 'path_type_vendor'; | |||
| private const PATH_TYPE_SELF = 'path_type_internal'; | |||
| private const PATH_TYPE_UNDETERMINED = 'path_type_undetermined'; | |||
There was a problem hiding this comment.
I could have used an exception instead of 3-value return, but it did not feel "exceptional" enough. This is going to happen whenever a deprecation comes from the cache.
There was a problem hiding this comment.
hello PHP 5.5, we cannot use these consts
fabpot
approved these changes
Jun 26, 2019
d67f50c to
d9f0ba3
Compare
|
Thank you @greg0ire. |
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
This PR was squashed before being merged into the 4.3 branch (closes #31730). Discussion ---------- [PhpUnitBridge] More accurate grouping | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Sometimes, you cannot easily know if code was written by a vendor or directly in the application, for instance if the code comes from a file in the cache. In that case, it is better not to classify the deprecation as direct or indirect. @jmsche please test this on your application when you can, I think you might be having that issue. Commits ------- d9f0ba3 [PhpUnitBridge] More accurate grouping
|
This breaks the CI and I cannot reproduce locally (yet), for deps=low/high jobs: Not a bug, just a side-effect of the CI. |
|
Reverted in 4814fd3 |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2019
* 4.3: Revert "bug #31730 [PhpUnitBridge] More accurate grouping (greg0ire)"
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2019
* 4.4: Revert "bug #31730 [PhpUnitBridge] More accurate grouping (greg0ire)"
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2019
…eg0ire)"" This reverts commit 4814fd3.
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2019
* 4.3: Reject phpunit-bridge v5 for now Revert "Revert "bug #31730 [PhpUnitBridge] More accurate grouping (greg0ire)""
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2019
* 4.4: Reject phpunit-bridge v5 for now Revert "Revert "bug #31730 [PhpUnitBridge] More accurate grouping (greg0ire)""
|
Revert reverted because actually it's not the issue, I'm loosing my mind on because I cannot reproduce locally :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, you cannot easily know if code was written by a vendor or
directly in the application, for instance if the code comes from a file
in the cache. In that case, it is better not to classify the deprecation
as direct or indirect.
@jmsche please test this on your application when you can, I think you might be having that issue.