[DI] highlight suspicious tests #31942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Jun 7, 2019
| @@ -340,6 +341,7 @@ class ConfigurationWithArrayNodeRequiringOneElement implements ConfigurationInte | |||
| { | |||
| public function getConfigTreeBuilder() | |||
| { | |||
| throw new \Exception(); | |||
There was a problem hiding this comment.
the test ensures we dont require a node to be present, if the user didnt configure anything. However the side effect is the config tree isnt even initialized ... so it doesnt matter much what happens here.
I'd keep this tree for the purpose of clarity, in the sense we don't expect an InvalidConfigException due nodes being required.
ro0NL
reviewed
Jun 7, 2019
| @@ -332,6 +332,7 @@ class EnvConfigurationWithoutRootNode implements ConfigurationInterface | |||
| { | |||
| public function getConfigTreeBuilder() | |||
| { | |||
| throw new \Exception(); | |||
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [DI] Fix suspicious test | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #31942 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> cc @nicolas-grekas Commits ------- 25b961a [DI] Fix suspicious test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why doesn't this break something?
Related to #27710 I think
/cc @xabbuh @ro0NL if you have any idea why :)