Dynamic bundle assets #31975

garak · 2019-06-10T11:25:45Z

Q	A
Branch?	4.4
Bug fix?	no
New feature?	yes
BC breaks?	no (new method in interface as annotation)
Deprecations?	no
Tests pass?	yes
Fixed tickets	#29213
License	MIT
Doc PR	none (yet)

Everything is explained in linked issue

derrabus · 2019-06-10T23:05:34Z

This PR should target the 4.4 branch. If you only add a @method annotation to the BundleInterface instead of the real method, it's not a BC break anymore.

src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php

garak · 2019-06-11T06:45:59Z

This PR should target the 4.4 branch. If you only add a @method annotation to the BundleInterface instead of the real method, it's not a BC break anymore.

So, should I close this PR and open another one on 4.4?

fabpot · 2019-06-20T06:41:38Z

@garak No, you change the target of this PR without creating a new one.

garak · 2019-06-20T06:51:52Z

@fabpot I just tried to change target to 4.4. and a bunch of stuff popped up.
Maybe a new PR is a better option... unless you can suggest a way to get rid of such mess
Thanks

fabpot · 2019-06-20T12:26:29Z

@garak rebase your PR locally on 4.4 and push again, that should resolve the mess.

garak · 2019-06-20T13:14:16Z

I rebased upon 4.4.
I followed suggestion from @derrabus and replaced actual method with an annotation inside interface.
I also updated initial PR comment.

Hope everything is fine

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

garak · 2019-06-29T15:16:47Z

I still see "Status: Needs Work" label. Should I do something else?

src/Symfony/Component/HttpKernel/Bundle/Bundle.php

garak · 2019-07-08T13:36:07Z

Friendly reminder: did needed work, do I need to do some more?

fabpot

Having some tests for this new feature would be nice as well.

src/Symfony/Component/HttpKernel/Bundle/Bundle.php

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

src/Symfony/Component/HttpKernel/Tests/KernelTest.php

garak · 2019-07-08T14:40:32Z

I addressed all notes from @fabpot, I guess. Some portions of code are not shown as modified, but they are, actually.
I also added a small expectation in tests, I couldn't find any direct tests of AssetsInstallCommand. Failures in CI are unrelated

fabpot · 2019-07-09T06:13:32Z

Thank you @garak.

This PR was squashed before being merged into the 4.4 branch (closes #31975). Discussion ---------- Dynamic bundle assets | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no (new method in interface as annotation) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29213 | License | MIT | Doc PR | none (yet) Everything is explained in linked issue Commits ------- c16fcc9 Dynamic bundle assets

…ereguiluz) This PR was squashed before being merged into the 4.4 branch (closes #32452). Discussion ---------- [Bundles] Rename getPublicPath() as getPublicDir() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | - | License | MIT | Doc PR | I'll add this if approved While documenting #31975 (see symfony/symfony-docs#11930) I realized that the `getPublicPath()` method name is not consistent with the rest of Symfony. In Symfony, "path" is usually associated to routes and we use "dir" for things similar to this: * `getCacheDir()` and `getLogdir()` to override Symfony structure (https://symfony.com/doc/current/configuration/override_dir_structure.html) * `binDir`, `configDir`, `srcDir`, `varDir`, `publicDir` in Symfony Flex recipes (https://github.com/symfony/recipes) to override the dir structure So, this PR proposes to rename `getPublicPath()` as `getPublicDir()` Commits ------- 4ab2f99 [Bundles] Rename getPublicPath() as getPublicDir()

Tobion · 2019-07-14T13:41:30Z

src/Symfony/Component/HttpKernel/Bundle/Bundle.php

@@ -135,6 +135,11 @@ public function registerCommands(Application $application)
    {
    }

+    public function getPublicPath(): string
+    {
+        return 'Resources/public';


IMO that should return the absolute dir to be consistent with getLogDir etc,

symfony/src/Symfony/Component/HttpKernel/Kernel.php

Line 346 in 08c80eb

return $this->getProjectDir().'/var/log';

@Tobion here we're not in the project context, but in the bundle one. Anyway, bundle always returned such path, this is not changing anything

…on for bundle directories (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32845). Discussion ---------- [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#32453 | License | MIT | Doc PR | TODO We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures. The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure. We have recently added the `getPublicDir()` method in symfony/symfony#31975, here I'm removing it in favor of hardcoding a new convention. I've added some functional tests in which I've changed everything to this structure: ``` -- ModernBundle |-- config/ |-- public/ |-- src/ |-- ModernBundle.php |-- templates/ |-- translations/ ``` WDYT? Commits ------- 6996e1cbe2 [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories

…on for bundle directories (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32845). Discussion ---------- [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32453 | License | MIT | Doc PR | TODO We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures. The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure. We have recently added the `getPublicDir()` method in #31975, here I'm removing it in favor of hardcoding a new convention. I've added some functional tests in which I've changed everything to this structure: ``` -- ModernBundle |-- config/ |-- public/ |-- src/ |-- ModernBundle.php |-- templates/ |-- translations/ ``` WDYT? Commits ------- 6996e1c [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories

…on for bundle directories (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32845). Discussion ---------- [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#32453 | License | MIT | Doc PR | TODO We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures. The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure. We have recently added the `getPublicDir()` method in symfony/symfony#31975, here I'm removing it in favor of hardcoding a new convention. I've added some functional tests in which I've changed everything to this structure: ``` -- ModernBundle |-- config/ |-- public/ |-- src/ |-- ModernBundle.php |-- templates/ |-- translations/ ``` WDYT? Commits ------- 6996e1cbe2 [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories

…on for bundle directories (yceruto) This PR was squashed before being merged into the 4.4 branch (closes #32845). Discussion ---------- [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#32453 | License | MIT | Doc PR | TODO We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures. The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure. We have recently added the `getPublicDir()` method in symfony/symfony#31975, here I'm removing it in favor of hardcoding a new convention. I've added some functional tests in which I've changed everything to this structure: ``` -- ModernBundle |-- config/ |-- public/ |-- src/ |-- ModernBundle.php |-- templates/ |-- translations/ ``` WDYT? Commits ------- 6996e1c [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories

carsonbot added Status: Needs Review Feature BC Break labels Jun 10, 2019

chalasr added this to the 5.0 milestone Jun 10, 2019

carsonbot removed the Status: Needs Review label Jun 10, 2019

derrabus requested changes Jun 10, 2019

View reviewed changes

src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php Outdated Show resolved Hide resolved

carsonbot added the Status: Needs Work label Jun 10, 2019

garak changed the base branch from master to 4.4 June 20, 2019 06:50

garak force-pushed the dynamic-bundle-assets branch from 535008f to 33ec2d8 Compare June 20, 2019 13:08

jvasseur reviewed Jun 20, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php Outdated Show resolved Hide resolved

derrabus requested changes Jun 29, 2019

View reviewed changes

src/Symfony/Component/HttpKernel/Bundle/Bundle.php Outdated Show resolved Hide resolved

fabpot requested changes Jul 8, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php Outdated Show resolved Hide resolved

src/Symfony/Component/HttpKernel/Tests/KernelTest.php Outdated Show resolved Hide resolved

fabpot approved these changes Jul 9, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jul 9, 2019

Dynamic bundle assets

c16fcc9

fabpot force-pushed the dynamic-bundle-assets branch from f99e81d to c16fcc9 Compare July 9, 2019 06:13

fabpot mentioned this pull request Jul 9, 2019

Dynamic bundle assets symfony/symfony-docs#11927

Closed

fabpot merged commit c16fcc9 into symfony:4.4 Jul 9, 2019

garak deleted the dynamic-bundle-assets branch July 9, 2019 06:38

This was referenced Jul 9, 2019

[Bundles] Rename getPublicPath() as getPublicDir() #32452

Merged

[Bundles] Allow to customize the entire dir structure #32453

Closed

xabbuh added HttpKernel FrameworkBundle and removed BC Break labels Jul 14, 2019

This was referenced Jul 14, 2019

fix some deprecations and add upgrade instructions #32533

Merged

remove deprecated features #32531

Merged

Tobion reviewed Jul 14, 2019

View reviewed changes

yceruto mentioned this pull request Aug 1, 2019

[HttpKernel][FrameworkBundle] Add alternative convention for bundle directories #32845

Merged

xabbuh mentioned this pull request Aug 26, 2019

[HttpKernel] do not mock removed getPublicDir() method #33336

Merged

This was referenced Nov 12, 2019

Release v4.4.0-BETA1 #34338

Merged

Release v5.0.0-BETA1 #34339

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic bundle assets #31975

Dynamic bundle assets #31975

garak commented Jun 10, 2019 •

edited

Loading

derrabus commented Jun 10, 2019

garak commented Jun 11, 2019

fabpot commented Jun 20, 2019

garak commented Jun 20, 2019

fabpot commented Jun 20, 2019

garak commented Jun 20, 2019

garak commented Jun 29, 2019

garak commented Jul 8, 2019

fabpot left a comment

garak commented Jul 8, 2019

fabpot commented Jul 9, 2019

Tobion Jul 14, 2019

garak Jul 14, 2019

Dynamic bundle assets #31975

Dynamic bundle assets #31975

Conversation

garak commented Jun 10, 2019 • edited Loading

derrabus commented Jun 10, 2019

garak commented Jun 11, 2019

fabpot commented Jun 20, 2019

garak commented Jun 20, 2019

fabpot commented Jun 20, 2019

garak commented Jun 20, 2019

garak commented Jun 29, 2019

garak commented Jul 8, 2019

fabpot left a comment

Choose a reason for hiding this comment

garak commented Jul 8, 2019

fabpot commented Jul 9, 2019

Tobion Jul 14, 2019

Choose a reason for hiding this comment

garak Jul 14, 2019

Choose a reason for hiding this comment

garak commented Jun 10, 2019 •

edited

Loading