Removed legacy code and cleanup #32160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a symfony/src/Symfony/Component/Form/FormConfigBuilder.php Lines 775 to 777 in 8124159 What's the planned alternative for this case? |
|
The plan was to make the method private. |
xabbuh
reviewed
Jun 25, 2019
@Tobion but it's used out there ( |
nicolas-grekas
approved these changes
Jun 25, 2019
|
Tests (low) are broken. |
|
Mmm, I'm not sure why, the broken tests are being eliminated here 🤔 |
fabpot
approved these changes
Jun 25, 2019
|
Tests green. |
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Jun 25, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #32160). Discussion ---------- Removed legacy code and cleanup | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See #32074, #26981 labels: `HttpFoundation`, `Form`, `Security`, `SecurityBundle`, `Validator` Commits ------- 7b99fb4 Removed legacy code and cleanup
fabpot
added a commit
that referenced
this pull request
Jun 26, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Form] remove comment about to-be-removed method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> it is used in master by ButtonBuilder, see #32160 (comment) Commits ------- b80ce9a [Form] remove comment about to-be-removed method as it is used in master by ButtonBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32074, #26981
labels:
HttpFoundation,Form,Security,SecurityBundle,Validator