[Csrf] Added type-hint for CsrfTokenMangerInterface #32208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
__toString method of CsrfToken return a string. |
derrabus
requested changes
Jun 27, 2019
src/Symfony/Component/Security/Csrf/CsrfTokenManagerInterface.php
Outdated
Show resolved
Hide resolved
57 tasks
4825474 to
80e28a0
Compare
79a2a0a to
44e5b0b
Compare
derrabus
approved these changes
Jun 27, 2019
fabpot
approved these changes
Jun 29, 2019
|
Thank you @julien57. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2019
…ien57) This PR was merged into the 5.0-dev branch. Discussion ---------- [Csrf] Added type-hint for CsrfTokenMangerInterface | Q | A | ------------- | --- | Branch? | Master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#.. Add type-hints in PR for CsrfTokenManagerInterface & CsrfTokenManager component. Commits ------- 44e5b0b removed return values
Tobion
added a commit
that referenced
this pull request
Jul 2, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [CSRF] add more parameter types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | /no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Those have been missing in #32208 Commits ------- d442028 [CSRF] add more parameter types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type-hints in PR for CsrfTokenManagerInterface & CsrfTokenManager component.