Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CSRF] add more parameter types #32285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Jun 29, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? /no
Tests pass? yes
Fixed tickets #32179
License MIT
Doc PR symfony/symfony-docs#...

Those have been missing in #32208

@derrabus
Copy link
Member

CI fails here because of one unit test that does not mock TokenGeneratorInterface properly. That test should probably be fixed on a lower branch.

@derrabus derrabus mentioned this pull request Jun 29, 2019
57 tasks
@Tobion Tobion force-pushed the csrf-more-parameter-types branch from abe4f78 to d442028 Compare June 29, 2019 22:40
@Tobion
Copy link
Contributor Author

Tobion commented Jun 29, 2019

Fixed

@Tobion Tobion added this to the 5.0 milestone Jun 29, 2019
@Tobion Tobion merged commit d442028 into symfony:master Jul 2, 2019
Tobion added a commit that referenced this pull request Jul 2, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[CSRF] add more parameter types

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | /no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Those have been missing in #32208

Commits
-------

d442028 [CSRF] add more parameter types
@Tobion Tobion deleted the csrf-more-parameter-types branch July 2, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants