[Serializer] Allow multi-dimenstion object array in AbstractObjectNormalizer #32832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added some additional fixes and a test in the normalizer |
|
I could fix the test just switching the type of the intMatrix to 'array', but then we are saying that typing as What do you think? |
alediator
commented
Aug 1, 2019
src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php
Outdated
Show resolved
Hide resolved
603f39f to
ea03f6d
Compare
|
Thank you @alediator. |
|
One question, it was submitted as bugfix, but merged into 4.4. Was this intended or a mistake, because there are no additional infos in the comments, if this was considered a new feature 🤔 cc @fabpot |
|
|
|
It was a pleasure to collaborate with this huge community! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify ´AbstractObjectNormalizer´ adding the capability of parsing nested arrays of objects instead of parsing them into arrays
I was trying to parse a nested array of objects and I'd find out with this #31175 behavior. After trying to solve in different ways, I was able to do it adding the fix that allows the
AbstractObjectNormalizerto parse more than one dimension array of objects.I would like to add some tests to assure it works and doesn't generate any side effects, but I'd prefer to open the PR to link it to the existing issue #31175.
On the other hand, if you think it is not applicable or you want me to change anything, please let me know.