-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] Add support for the profiler #32912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f143ee4
to
d4364c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we port the iframe approach from swiftmailer for rendering HTML while at it?
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/mailer.html.twig
Outdated
Show resolved
Hide resolved
a838f9c
to
a54e8ee
Compare
Travis failure will be fixed when 4.4 is merged to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've reviewed this and I can't see any obvious error. It's true that we're missing the "HTML preview" feature, but as Fabien said, that can be done in separate PRs after merging this one.
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Add support for the profiler | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | closes #31592 | License | MIT | Doc PR | n/a Web profiler for the Mailer. Commits ------- f152314 [Mailer] added support for the profiler
did anyone worked on this ? I did that on a project to embed <iframe
src="data:text/html;base64;charset=utf-8,{{ phpinfo|raw|base64_encode }}"
style="height: 80vh;width: 100%;"
>
</iframe> (Note: the |
Yes, see swiftmailerbundle :) |
@ro0NL But it's not in symfony/mailer, right ? |
Web profiler for the Mailer.