Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Add support for the profiler #32912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 3, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets closes #31592
License MIT
Doc PR n/a

Web profiler for the Mailer.

@fabpot
Copy link
Member Author

fabpot commented Aug 3, 2019

image

image

@fabpot fabpot force-pushed the mailer-profiler branch 2 times, most recently from f143ee4 to d4364c5 Compare August 3, 2019 20:39
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we port the iframe approach from swiftmailer for rendering HTML while at it?

@fabpot fabpot force-pushed the mailer-profiler branch 2 times, most recently from a838f9c to a54e8ee Compare August 4, 2019 20:34
@fabpot
Copy link
Member Author

fabpot commented Aug 4, 2019

I think it's finished now. It supports multiple transports and I've added a visual representation of the message parts.

image

Regarding the iframe for HTML, it's not simple and I'd like to do it in a follow-up PR (or maybe someone else can work on it :)).

@fabpot
Copy link
Member Author

fabpot commented Aug 5, 2019

Travis failure will be fixed when 4.4 is merged to master.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've reviewed this and I can't see any obvious error. It's true that we're missing the "HTML preview" feature, but as Fabien said, that can be done in separate PRs after merging this one.

@fabpot fabpot merged commit f152314 into symfony:4.4 Aug 5, 2019
fabpot added a commit that referenced this pull request Aug 5, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Add support for the profiler

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | closes #31592
| License       | MIT
| Doc PR        | n/a

Web profiler for the Mailer.

Commits
-------

f152314 [Mailer] added support for the profiler
@fabpot fabpot deleted the mailer-profiler branch August 5, 2019 16:41
@lyrixx
Copy link
Member

lyrixx commented Aug 22, 2019

Regarding the iframe for HTML, it's not simple and I'd like to do it in a follow-up PR (or maybe someone else can work on it :)).

did anyone worked on this ?

I did that on a project to embed phpinfo() in a debug page (because we don't trust our hosting platform 😂 and we needed to check things)

            <iframe
                src="data:text/html;base64;charset=utf-8,{{ phpinfo|raw|base64_encode }}"
                style="height: 80vh;width: 100%;"
            >
            </iframe>

(Note: the raw looks useless...)

@ro0NL
Copy link
Contributor

ro0NL commented Aug 22, 2019

did anyone worked on this ?

Yes, see swiftmailerbundle :)

@lyrixx
Copy link
Member

lyrixx commented Aug 22, 2019

@ro0NL But it's not in symfony/mailer, right ?

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mailer does not collect profiling
6 participants