Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Add a name to the transports #32916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2019
Merged

[Mailer] Add a name to the transports #32916

merged 1 commit into from
Aug 4, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 4, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Having a name for Transports helps identify them (useful for instance in the profiler when one uses several mailers).

@fabpot fabpot added the Mailer label Aug 4, 2019
@fabpot fabpot added this to the next milestone Aug 4, 2019
@fabpot fabpot force-pushed the mailer-transport-name branch 2 times, most recently from a300795 to 0b368eb Compare August 4, 2019 04:07
@fabpot fabpot changed the title [Mailer] Add a name to the transport [Mailer] Add a name to the transports Aug 4, 2019
@fabpot fabpot force-pushed the mailer-transport-name branch from 0b368eb to 2412dfe Compare August 4, 2019 04:22
@fabpot fabpot mentioned this pull request Aug 4, 2019
Closed
@fabpot fabpot merged commit 2412dfe into symfony:4.4 Aug 4, 2019
fabpot added a commit that referenced this pull request Aug 4, 2019
@fabpot
feature #32916 [Mailer] Add a name to the transports (fabpot)
37265de 
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Add a name to the transports

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Having a name for Transports helps identify them (useful for instance in the profiler when one uses several mailers).

Commits
-------

2412dfe [Mailer] added a name to the transport
@fabpot fabpot deleted the mailer-transport-name branch August 5, 2019 16:41
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Mailer Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @nicolas-grekas @carsonbot