Prevent ProgressBar redraw when message is same #33884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b44b9c6 to
dbf9b4d
Compare
|
Thank you. The PR should target 4.4 as it's more an improvement than a bug fix. |
0142216 to
40210a5
Compare
|
@nicolas-grekas Done. I wasn't really sure whether to consider it bugfix or improvement. |
nicolas-grekas
approved these changes
Oct 7, 2019
chalasr
approved these changes
Oct 7, 2019
992aaab to
78b515f
Compare
|
Thank you @fmasa. |
|
Thank you both for quick feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents ProgressBar from performing unnecessary redrawes if new output is same as current one. This is mostly useful when working with multiple progress bars. Same behavior can enforced by carefully setting redraw frequency, but I don't see any downsides for smarter redrawing by default.
This can be moved to
if ($this->overwrite)if necessary, so it's applied only in case overwriting is enabled.