[4.3] Remove unused local variables #34176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44bcd6f to
3783a60
Compare
|
fabbot changes should not be applied. |
src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php
Outdated
Show resolved
Hide resolved
| @@ -121,7 +121,7 @@ static function (\$condition, \$context, \$request) { // \$checkCondition | |||
| } | |||
| } | |||
| EOF; | |||
| $compiledRoutes[4] = $forDump ? $checkConditionCode .= ",\n" : eval('return '.$checkConditionCode.';'); | |||
| $compiledRoutes[4] = $forDump ? $checkConditionCode.",\n" : eval('return '.$checkConditionCode.';'); | |||
There was a problem hiding this comment.
I've seen this updated in the previous PR also and still merged - but FYI this is not exactly the same: using .= provides better memory usage (maybe the engine does the optimization already, I don't know).
But ok to change anyway.
There was a problem hiding this comment.
Thanks for the explanation. I assumed a simple concat is faster than an assign + concat. It might worth it to take a look or to revert those changes. I don't want to cause a performance regression just by trying to "clean" the code.
3783a60 to
7d8897c
Compare
7d8897c to
58161b8
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #34105 on 4.3. Commits ------- 58161b8 [4.3] Remove unused local variables
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony#34105 on 4.3. Commits ------- 58161b8 [4.3] Remove unused local variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #34105 on 4.3.