Fixed profiler report under an exception of a sub-request #3609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,8 @@ protected function createProfileFromData($token, $data, $parent = null) | |||
| $profile->setTime($data['time']); | |||
| $profile->setCollectors(unserialize(base64_decode($data['data']))); | |||
|
|
|||
| if (!$parent && !empty($data['parent'])) { | |||
| // Under sub-requests, $data['parent'] === $token in an exception situation | |||
| if ( ! $parent && isset($data['parent']) && $data['parent'] && $data['parent'] !== $token) { | |||
There was a problem hiding this comment.
This is not Doctrine ;). Spaces around ! aren't needed.
|
@Koc done! |
|
@guilhermeblanco have you checked other storages for the same defect ? |
|
@guilhermeblanco can you resend the PR to the 2.0 branch as it is a bugfix ? |
|
@guilhermeblanco could you please create a ticket so that it doesn't get lost (referencing the PR). Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sub-request contains an exception, PdoProfilerStorage was entering in an infinite loop.
Fixed by preventing the read/createProfileFromData recursion.