[DoctrineBridge] Bumps doctrine/persistence to version 2.x #37416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Jun 26, 2020
| @@ -19,7 +19,7 @@ | |||
| "php": ">=7.2.5", | |||
| "ext-xml": "*", | |||
| "doctrine/event-manager": "~1.0", | |||
| "doctrine/persistence": "^1.3", | |||
| "doctrine/persistence": "^2.0", | |||
|
This should target branch 3.4 and compat with 1.* should be preserved. |
|
Closing as staled, please resubmit when ready. |
|
I've had a quick look.
On the 3.4 branch, we don't have any version constraints for doctrine/persistence. On 4.4 and above, we're still blocked by |
|
Continuation: #37639 |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 23, 2020
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Allow doctrine/persistence 2 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Replaces #37416. This PR unblocks the installation of `doctrine/persistence` version 2. Notes: * I had to bump `doctrine/data-fixtures` because composer would otherwise downgrade to an ancient alpha release with incomplete version constraints. This package is a dev dependency for our tests, so I think we're good here. **edit**: Moved to #37640. * Until doctrine/data-fixtures#349 has been resolved, Doctrine/Bridge cannot be tested with version 2 of `doctrine/persistence`. Commits ------- cd22fe6 Allow doctrine/persistence 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for doctrine/persistence version to 2.x. As it's a new major version, I've targeted the master branch. Relates to doctrine/DoctrineBundle#1181
Awating pull request to be merged in dependency doctrine/data-fixtures: doctrine/data-fixtures#349