[Yaml] do not dump extra trailing newlines for multiline blocks#39668
[Yaml] do not dump extra trailing newlines for multiline blocks#39668fabpot merged 1 commit intosymfony:4.4from
Conversation
xabbuh
commented
Dec 31, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #38310 |
| License | MIT |
| Doc PR |
|
Thank you @xabbuh. |
|
Thanks everyone for caring for and putting time and energy into this! (I'm the person who raised the issue and its predecessor. ;-) Reviewing the code (unfortunataly i did not catch the unmerged-PR time window), i'm quite sure that this causes regressions:
What to do? Yaml spec is a convoluted piece of art. Sorry for not having the bandwidth to forge this into a new PR, but HTH. |
|
@geek-merlin Thank you for coming back to this. I am going to check the current code with the YAML example that you linked. |
|
For a radically different multiline alternative see #39682. It does not help with this bugfix, but being in the enlightened state of having groked this corner of Yaml, i quickly needed to do a braindump. |
|
see #39683 for fixing this regression |
…ngs (xabbuh) This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] keep trailing newlines when dumping multi-line strings | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39668 (comment) | License | MIT | Doc PR | Commits ------- 4c513c2 keep trailing newlines when dumping multi-line strings