Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Yaml] keep trailing newlines when dumping multi-line strings #39683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 2, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39668 (comment)
License MIT
Doc PR

@fabpot
Copy link
Member

fabpot commented Jan 3, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit a902dd8 into symfony:4.4 Jan 3, 2021
@xabbuh xabbuh deleted the pr-39668 branch January 3, 2021 08:38
@geek-merlin
Copy link

Thanks Christian @xabbuh for working on this! First impression, i have doubts about this and will look deeper into this and make a writeup. My timeframe now is ~1/2h, so either i can do it now, or stay tuned tomorrow.

@xabbuh
Copy link
Member Author

xabbuh commented Jan 3, 2021

@geek-merlin Thank you for your valuable feedback. Please do not hesitate to leave comments if you discover more edge cases that do not work as expected. I'll be happy to look into them.

@geek-merlin
Copy link

Short story: I had some concerns about edge cases of the foreach loop but on closer look all seems fine.

And now i see that you're coming from the test-first camp, so i'll provide pre-cooked tests in the future.

So i guess for now the trailing-newline issue is settled, and hopefully we can finally use that in Drupal's config dumper.

I guess that we still have some unicode issues with this, so i'm interested in architectural feedback on #39682.

This was referenced Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants