Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Symfony Armenian Translations #39809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

Symfony Armenian Translations #39809

merged 1 commit into from
Feb 16, 2021

Conversation

azatyan
Copy link
Contributor

@azatyan azatyan commented Jan 13, 2021 •
edited by derrabus
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38724
License MIT
Doc PR -

@carsonbot
Copy link

Hey!

I had a quick look at this PR, I think it is alright.

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@azatyan azatyan changed the title Validators hy 2021 Symfony Armenian Translations Jan 13, 2021
@azatyan
Copy link
Contributor Author

azatyan commented Jan 13, 2021

Hey @carsonbot thank you for your advice.

@azatyan azatyan marked this pull request as ready for review January 13, 2021 07:06
Nyholm
Nyholm reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this.

I used Google Translate to try to verify these. We will see if we can find another native speaker to review this too.

@Nyholm Nyholm added this to the 4.4 milestone Jan 13, 2021
azatyan
azatyan commented Jan 13, 2021
View reviewed changes
Copy link
Contributor Author

@azatyan azatyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to go to break lunch. Waiting reviews, bro!

@Nyholm Nyholm mentioned this pull request Jan 13, 2021
Closed
@wouterj wouterj removed their request for review January 13, 2021 11:40
@OskarStark
Copy link
Contributor

Friendly ping @Nyholm, how to proceed here?

@azatyan
Copy link
Contributor Author

azatyan commented Jan 28, 2021

I don't sure, I can help in this days, as too much busy with learning.
But I hope, after Feb Q2 maybe will have a enough energy to help community.

@azatyan
Copy link
Contributor Author

azatyan commented Feb 16, 2021

Who can assist me, which translations are not translated? And in which branch of Symfony we need to work.
ping @Nyholm

@Nyholm
Copy link
Member

Nyholm commented Feb 16, 2021

I think we covered all translations here.

I suggest merging this PR in its current state.

@fabpot fabpot changed the base branch from 5.x to 4.4 February 16, 2021 07:10
@fabpot fabpot force-pushed the validators_hy_2021 branch from b579b02 to 93fe4a2 Compare February 16, 2021 07:10
@fabpot
Copy link
Member

fabpot commented Feb 16, 2021

Thank you @azatyan.

@fabpot fabpot merged commit 89d7097 into symfony:4.4 Feb 16, 2021
@azatyan
Copy link
Contributor Author

azatyan commented Feb 16, 2021

Thank you too, @fabpot for merging. If in future I've found any typos will report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm left review comments

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Missing translations Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Missing translations for Armenian (hy)
7 participants
@azatyan @carsonbot @OskarStark @Nyholm @fabpot @Hakadel @derrabus