-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
remove references to "Silex" #40685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove references to "Silex" #40685
Conversation
a1812
commented
Apr 2, 2021
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #40681 |
License | MIT |
Doc PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I agree that Silex references should not be around. Could we reword the comments a bit? I did a suggestion but Im not sure that is the best solution.
src/Symfony/Component/HttpFoundation/Session/Storage/MockFileSessionStorage.php
Outdated
Show resolved
Hide resolved
@@ -3,8 +3,7 @@ HttpKernel Component | |||
|
|||
The HttpKernel component provides a structured process for converting a Request | |||
into a Response by making use of the EventDispatcher component. It's flexible | |||
enough to create a full-stack framework (Symfony), a micro-framework (Silex) or | |||
an advanced CMS system (Drupal). | |||
enough to create full-stack frameworks, micro-frameworks or advanced CMS system like Drupal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systems
should also be plural, like previous items in the list.
Thank you |