Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove references to "Silex" #40685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021
Merged

remove references to "Silex" #40685

merged 1 commit into from
Apr 2, 2021

Conversation

a1812
Copy link
Contributor

@a1812 a1812 commented Apr 2, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40681
License MIT
Doc PR

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I agree that Silex references should not be around. Could we reword the comments a bit? I did a suggestion but Im not sure that is the best solution.

@@ -3,8 +3,7 @@ HttpKernel Component

The HttpKernel component provides a structured process for converting a Request
into a Response by making use of the EventDispatcher component. It's flexible
enough to create a full-stack framework (Symfony), a micro-framework (Silex) or
an advanced CMS system (Drupal).
enough to create full-stack frameworks, micro-frameworks or advanced CMS system like Drupal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

systems should also be plural, like previous items in the list.

@Nyholm
Copy link
Member

Nyholm commented Apr 2, 2021

Thank you

@Nyholm Nyholm merged commit 2a3f912 into symfony:4.4 Apr 2, 2021
@a1812 a1812 deleted the issue_40681 branch July 21, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants