Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Routing] allow extending Route attribute #41014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2021
Merged

[Routing] allow extending Route attribute #41014

merged 1 commit into from
May 1, 2021

Conversation

robmro27
Copy link
Contributor

@robmro27 robmro27 commented May 1, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

There is probably missed \ReflectionAttribute::IS_INSTANCEOF parameter and because of that Route attribute class could not be extended. This could be used by some popular bundles like FOSRestBundle for example. Right
now it's not possible to add attributes support there like it was before (extending Route Annotation).

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas added this to the 5.3 milestone May 1, 2021
@nicolas-grekas nicolas-grekas changed the title [Routing] - allow extend Route attribute [Routing] allow extending Route attribute May 1, 2021
@robmro27 robmro27 mentioned this pull request May 1, 2021
Closed
@robmro27
Copy link
Contributor Author

robmro27 commented May 1, 2021 •
edited
Loading

Hey thanks for quick check. Is this continuous-integration/appveyor/pr AppVeyor build failed something I should fix somehow ?

@nicolas-grekas
Copy link
Member

The failing test is unrelated.

@fabpot fabpot force-pushed the allow_extend_route_annotation branch from 8dceaf2 to d733b78 Compare May 1, 2021 14:20
@fabpot
Copy link
Member

fabpot commented May 1, 2021

Thank you @robmro27.

@fabpot fabpot merged commit 4cc0ab3 into symfony:5.x May 1, 2021
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@robmro27 @carsonbot @nicolas-grekas @fabpot @derrabus