[Security] Fix wrong cache directive when using the new PUBLIC_ACCESS attribute #42596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91c66dc to
a7b370f
Compare
wouterj
commented
Aug 17, 2021
| @@ -50,7 +50,7 @@ public function hashPassword($user, string $plainPassword): string | |||
| } elseif ($user instanceof UserInterface) { | |||
| $salt = $user->getSalt(); | |||
|
|
|||
| if (null !== $salt) { | |||
| if ($salt) { | |||
There was a problem hiding this comment.
getSalt() is typehinted as @return string, so null would be invalid. This check is now also in sync with the same deprecation check in CheckCredentialsListener.
jderusse
reviewed
Aug 17, 2021
...ecurityBundle/Tests/Functional/Bundle/RememberMeBundle/Security/UserChangingUserProvider.php
Show resolved
Hide resolved
fabpot
approved these changes
Aug 17, 2021
chalasr
approved these changes
Aug 17, 2021
a7b370f to
ca80ee3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUBLIC_ACCESSis the newIS_AUTHENTICATED_ANONYMOUSLYsince 5.2, but we didn't correctly check for this causing a private cache directive for a stateless page.This PR also includes 2 changes from #42595 that could be backported to 5.3