[ErrorHandler] Fix FlattenException::setPrevious argument typing #44028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
326756e to
21ec2b8
Compare
|
Can you please target 4.4? |
21ec2b8 to
64143dd
Compare
chalasr
approved these changes
Nov 12, 2021
fabpot
approved these changes
Nov 12, 2021
|
Thank you @welcoMattic. |
This was referenced Nov 14, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setter didn't accept
nullvalue, while the getter can returnnull. It can be a fix for the linked issue, but I'm not 100% sure about the cause of the issue (I'll try to make a reproducer soon).In the meantime, this typing bug seems to fix at least the case explained in the issue.