Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Hey!

I think @HeahDude has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Can you please add a test case for what Fabien described in #37622 (comment) to make sure that we do not break those use cases?

Will this also fix #37615?

Will this also fix #37615?

@xabbuh Yes it will also fix, i wrote test for that

Can you please add a test case for what Fabien described in #37622 (comment) to make sure that we do not break those use cases?

@xabbuh For that maybe I'm wrong but testGetValueIgnoresMagicGet covers this case no ?

Not sure, if I don't miss anything, that test was already present at the time #37622 was merged.

Not sure, if I don't miss anything, that test was already present at the time #37622 was merged.

@xabbuh Ok, i also wrote test for that

Hi, Did you have time to watch ? @xabbuh thx :)

Thank you @kevcomparadise.