[Messenger] Store millisecond timestamps as float instead of int to prevent int overflow issues on 32 bit based systems #44797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13c3888 to
0681a8a
Compare
f8ad7f6 to
0681a8a
Compare
…verflow issues on 32 bit based systems. Issue symfony#43860
0681a8a to
a65fdf0
Compare
|
Closing in favor of #44807 Thanks for giving it a try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Redis transport use a score variabel to calculate when a message can be handeld after an failure (retry delay).
This is based on a timestamp in milliseconds and saved in PHP as an integer. On 32 bit based systems (Raspberry Pi for example) an integer overflow will happen, due to this overflow the score calculation is faulty and the message will 'never' be retried.
Redis internaly use double floats so we can use floats to in PHP.
Demo application can be found here https://github.com/maartendekeizer/symfony-issue-43860