[Messenger] fix Redis support on 32b arch #44807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67bd238 to
5af63a1
Compare
50bc130 to
9299842
Compare
2e9d35b to
652c020
Compare
|
Hey! I think @LukeTowers has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
ab6cf95 to
29c8349
Compare
cae963c to
1bb14c3
Compare
1bb14c3 to
742279c
Compare
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to fix it, but PR is now ready. We have to use
rawCommand()to work around phpredis casting scores to floats and ignoring any overflow/loss of precision in the process. Passing the score as a string is required here (note that Redis always stores numbers as 64b floats, even when running on x86)