-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Cache] Optimize caching of tags #45896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
Thanks for having another look :) |
P.1 and p.2 don't change the number of roundtrips, they just force the adapter to always work the same and not to rely on quasi-uniqueness of tag versions in some situations. P.3 may change the number of roundtrips but only downward by allowing large sets of tags (500+) to be cached for the very next reads (until other tags are requested). And although smaller sets are not affected much, I would suggest to use pruning instead of LRU cut-off. Pruning only expired tags would allow use of all known tags in any read operaion during their TTLs (as it was before). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my (miss)understanding of your proposal :)
78fff0c
to
7d0735c
Compare
7d0735c
to
a366300
Compare
9763ed0
to
1ccd607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last question and good to me!
1ccd607
to
e53f742
Compare
82ca189
to
0faaa75
Compare
0faaa75
to
68f309b
Compare
Thank you @sbelyshkin. |
It's the follow-up to #42997.