[HttpClient] Fix sending content-length when streaming the body #45998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Apr 11, 2022
stof
approved these changes
Apr 11, 2022
|
Thank you @nicolas-grekas. |
This was referenced Apr 27, 2022
Merged
Merged
Merged
|
For the record, I had strange and random HTTP errors that I could not explain with Upgrading to 5.4.9 has fixed the issue, thanks to this PR I think. So thank you @nicolas-grekas! |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 13, 2023
…as-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] Let curl handle content-length headers | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47973, #46499, #46823 | License | MIT | Doc PR | - I'm not sure why (maybe some older and buggy curl versions?) but it looks like curl might send content-length headers to proxies. This didn't happen before #45261 so I'm trying to use curl in the same was as we did by the time, aka letting it handle content-length header when possible. This is something that I already attempted in #45814 but was partly reverted in #45998. The attached patch is free from such issue. Commits ------- 5b27dc2 [HttpClient] Let curl handle content-length headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #45906 and previous PRs on the topic.
This PR partly reverts previous changes but keeps tests added to cover how we manage content-related headers when redirecting.
Relying on curl doesn't work in all cases, so we need to manage them on our own.