Introduce FlashBagAwareSessionInterface #46491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the Ci failures are not related to this PR. |
chalasr
reviewed
Jun 11, 2022
| interface FlashBagAwareSessionInterface extends SessionInterface | ||
| { | ||
| /** | ||
| * Gets the flashbag interface. |
|
@nicolas-grekas Hi, do you have some time to take a look at this proposal ? Thanks =) |
|
Thank you @VincentLanglet. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2022
…(VincentLanglet) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- Add deprecation when the session is not FlashBagAware | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes<!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Follow up of #46491 Since there is now an interface for the `getFlashBag` method, we should add the check in the `addFlash` method. Commits ------- 76bb064 Add deprecation when the session is not FlashBagAware
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solve #41765
People will be able to write
This is better than a
instanceof Sessioncheck (which is not working with decoration).