Add deprecation when the session is not FlashBagAware #46831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abab6e5 to
1d48f20
Compare
fabpot
requested changes
Jul 3, 2022
| '6.2', | ||
| 'Calling addFlash method when the session does not implements %s is deprecated.', | ||
| FlashBagAwareSessionInterface::class | ||
| ); |
There was a problem hiding this comment.
should be on one line to be consistent with the code base.
| trigger_deprecation( | ||
| 'symfony/framework-bundle', | ||
| '6.2', | ||
| 'Calling addFlash method when the session does not implements %s is deprecated.', |
There was a problem hiding this comment.
Suggested change
| 'Calling addFlash method when the session does not implements %s is deprecated.', | |
| 'Calling "addFlash()" method when the session does not implement %s is deprecated.', |
1988d7e to
24a9dd5
Compare
fabpot
approved these changes
Jul 4, 2022
|
Thank you @VincentLanglet. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2022
…(VincentLanglet) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- Add deprecation when the session is not FlashBagAware | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes<!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Follow up of #46491 Since there is now an interface for the `getFlashBag` method, we should add the check in the `addFlash` method. Commits ------- 76bb064 Add deprecation when the session is not FlashBagAware
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #46491
Since there is now an interface for the
getFlashBagmethod, we should add the check in theaddFlashmethod.