[PropertyInfo] Fix multi phpdoc covered promoted properties #46611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @Korbeil has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
There was a problem hiding this comment.
/cc @ostrolucky in case you can come up with another failing test case? or is this robust enough?
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
|
With this, maybe my patch at #46453 is not necessary anymore? |
|
Going to answer my own comment if (self::MUTATOR === $source && !$this->filterDocBlockParams($phpDocNode, $property)) {
return null;
}this guard can now indeed by removed, since you added more generic solution. |
…d properties This demonstrates that symfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
|
Indeed, cool |
ostrolucky
approved these changes
Jun 10, 2022
nicolas-grekas
approved these changes
Jun 10, 2022
|
Thank you @simPod. |
|
And thank you @ostrolucky also. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came up with this solution