[PropertyInfo] Add failing test case for multi phpdoc covered promoted properties #46550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d properties This demonstrates that symfony#46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
878b6ce to
5815fb7
Compare
|
Closing as part of #46611 |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 10, 2022
…s (ostrolucky, simPod) This PR was merged into the 6.1 branch. Discussion ---------- [PropertyInfo] Fix multi phpdoc covered promoted properties | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | Tickets | Fix #46550 | License | MIT I came up with this solution Commits ------- f503e37 [PropertyInfo] Fix multi phpdoc covered promoted properties 1605b57 [PropertyInfo] Add failing test case for multi phpdoc covered promoted properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failing test case demonstrates that #46056 causes yet another regression and even originally introduced functionality doesn't work properly.
Can you take a look @simPod ?