Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Centralize max username length enforcement #46618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2022
Merged

[Security] Centralize max username length enforcement #46618

merged 1 commit into from
Jun 9, 2022

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jun 7, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Cleans up the max username length enforcement across the board. Authenticators do not need to check it on their own since #46584.

@chalasr chalasr requested a review from wouterj as a code owner June 7, 2022 22:26
@carsonbot carsonbot added this to the 6.2 milestone Jun 7, 2022
@chalasr chalasr force-pushed the dedup-username-maxlen branch from b1520c2 to 9fd1e82 Compare June 7, 2022 22:27
@fabpot
Copy link
Member

fabpot commented Jun 9, 2022

Thank you @chalasr.

@fabpot fabpot merged commit aaa821b into symfony:6.2 Jun 9, 2022
@chalasr chalasr deleted the dedup-username-maxlen branch June 9, 2022 08:49
chalasr added a commit to chalasr/symfony that referenced this pull request Jun 10, 2022
@chalasr
Revert "minor symfony#46618 [Security] Centralize max username length…
d0bfcce 
… enforcement (chalasr)"

This reverts commit aaa821b, reversing
changes made to 292f6da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @fabpot @OskarStark @carsonbot