Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Centralize max username length enforcement #46618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022
Merged

[Security] Centralize max username length enforcement #46618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Symfony/Component/Security/Core/Security.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ class Security implements AuthorizationCheckerInterface
public const LAST_USERNAME = '_security.last_username';

/**
* @deprecated since Symfony 6.2, use \Symfony\Component\Security\Http\Authenticator\AuthenticatorInterface::MAX_USERNAME_LENGTH instead
*
* In 7.0, move this constant to the NewSecurityHelper class and make it reference AuthenticatorInterface:MAX_USERNAME_LENGTH.
* @deprecated since Symfony 6.2, use \Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge::MAX_USERNAME_LENGTH instead
*/
public const MAX_USERNAME_LENGTH = 4096;

Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/Security/Http/Authenticator/AuthenticatorInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
*/
interface AuthenticatorInterface
{
public const MAX_USERNAME_LENGTH = 4096;

/**
* Does the authenticator support the given Request?
*
Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Component/Security/Http/Authenticator/FormLoginAuthenticator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,6 @@ private function getCredentials(Request $request): array

$credentials['username'] = trim($credentials['username']);

if (\strlen($credentials['username']) > self::MAX_USERNAME_LENGTH) {
throw new BadCredentialsException('Invalid username.');
}

$request->getSession()->set(SecurityRequestAttributes::LAST_USERNAME, $credentials['username']);

return $credentials;
Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Component/Security/Http/Authenticator/JsonLoginAuthenticator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,6 @@ private function getCredentials(Request $request)
if (!\is_string($credentials['username'])) {
throw new BadRequestHttpException(sprintf('The key "%s" must be a string.', $this->options['username_path']));
}

if (\strlen($credentials['username']) > self::MAX_USERNAME_LENGTH) {
throw new BadCredentialsException('Invalid username.');
}
} catch (AccessException $e) {
throw new BadRequestHttpException(sprintf('The key "%s" must be provided.', $this->options['username_path']), $e);
}
Expand Down
8 changes: 4 additions & 4 deletions src/Symfony/Component/Security/Http/Tests/Authenticator/FormLoginAuthenticatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
use Symfony\Component\Security\Core\User\InMemoryUserProvider;
use Symfony\Component\Security\Http\Authentication\AuthenticationFailureHandlerInterface;
use Symfony\Component\Security\Http\Authentication\AuthenticationSuccessHandlerInterface;
use Symfony\Component\Security\Http\Authenticator\AuthenticatorInterface;
use Symfony\Component\Security\Http\Authenticator\FormLoginAuthenticator;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\CsrfTokenBadge;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\PasswordUpgradeBadge;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge;
use Symfony\Component\Security\Http\HttpUtils;
use Symfony\Component\Security\Http\Tests\Authenticator\Fixtures\PasswordUpgraderProvider;

Expand Down Expand Up @@ -50,7 +50,7 @@ public function testHandleWhenUsernameLength($username, $ok)
$this->expectNotToPerformAssertions();
} else {
$this->expectException(BadCredentialsException::class);
$this->expectExceptionMessage('Invalid username.');
$this->expectExceptionMessage('Username too long.');
}

$request = Request::create('/login_check', 'POST', ['_username' => $username, '_password' => 's$cr$t']);
Expand All @@ -62,8 +62,8 @@ public function testHandleWhenUsernameLength($username, $ok)

public function provideUsernamesForLength()
{
yield [str_repeat('x', AuthenticatorInterface::MAX_USERNAME_LENGTH + 1), false];
yield [str_repeat('x', AuthenticatorInterface::MAX_USERNAME_LENGTH - 1), true];
yield [str_repeat('x', UserBadge::MAX_USERNAME_LENGTH + 1), false];
yield [str_repeat('x', UserBadge::MAX_USERNAME_LENGTH - 1), true];
}

/**
Expand Down
7 changes: 4 additions & 3 deletions src/Symfony/Component/Security/Http/Tests/Authenticator/JsonLoginAuthenticatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use Symfony\Component\Security\Core\User\InMemoryUserProvider;
use Symfony\Component\Security\Http\Authenticator\AuthenticatorInterface;
use Symfony\Component\Security\Http\Authenticator\JsonLoginAuthenticator;
use Symfony\Component\Security\Http\Authenticator\Passport\Badge\UserBadge;
use Symfony\Component\Security\Http\Authenticator\Passport\Credentials\PasswordCredentials;
use Symfony\Component\Security\Http\HttpUtils;
use Symfony\Component\Translation\Loader\ArrayLoader;
Expand Down Expand Up @@ -121,9 +122,9 @@ public function provideInvalidAuthenticateData()
$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], '{"username": "dunglas", "password": 1}');
yield [$request, 'The key "password" must be a string.'];

$username = str_repeat('x', AuthenticatorInterface::MAX_USERNAME_LENGTH + 1);
$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], sprintf('{"username": "%s", "password": 1}', $username));
yield [$request, 'Invalid username.', BadCredentialsException::class];
$username = str_repeat('x', UserBadge::MAX_USERNAME_LENGTH + 1);
$request = new Request([], [], [], [], [], ['HTTP_CONTENT_TYPE' => 'application/json'], sprintf('{"username": "%s", "password": "foo"}', $username));
yield [$request, 'Username too long.', BadCredentialsException::class];
}

public function testAuthenticationFailureWithoutTranslator()
Expand Down