[Mailer] Fix error message in case of an STMP error #47142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
447a9e3 to
7ecebff
Compare
d1a3b74 to
f78149c
Compare
nicolas-grekas
approved these changes
Aug 1, 2022
f78149c to
f5448a2
Compare
f5448a2 to
aee6d08
Compare
|
fabbot green now :) |
|
Thank you @fabpot. |
|
I couldn't merge this change into 6.1 because it conflicted with changes made in #44446 |
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better exception messages are generally done in the "main" branch, but this one is quite nasty as it masks the actual error message from the SMTP server, so I think it deserves to be merged in 4.4.