Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Filesystem] Remove needless mb_* calls #47155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

[Filesystem] Remove needless mb_* calls #47155

wants to merge 0 commits into from

Conversation

HellFirePvP
Copy link

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47137
License MIT
Doc PR None

Issue fixed by adjusting to mb_strrpos to return expected index.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix should be to drop all mb_ prefix in this class as they don't serve any purpose.
Can you please do the change?

@nicolas-grekas
Copy link
Member

Just keep the call to mb_detect_encoding but please add two more arguments to it: null, true.

@HellFirePvP
Copy link
Author

I will split off the removal of mb_ sensitive string operations into a different PR and link it here as it's not directly connected to the original issue.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Aug 2, 2022

But the original issue is caused by these useless calls to mb_ so this topic cannot be split in two PRs (merging this PR as is doesn't make sense since it only builds on a preexisting mistake).

@HellFirePvP
Copy link
Author

As mentioned, mb operations were left in for lowercasing as character lowercasing might differ from internal language lowercasing strategy.
Removed the $encoding parameter from strtolower as it does not have a 2nd parameter.

@nicolas-grekas nicolas-grekas changed the title [Filesystem] Adjusted strrpos to mb_strrpos as substring expects mb index [Filesystem] Remove needless mb_* calls Aug 2, 2022
@nicolas-grekas
Copy link
Member

Thank you @HellFirePvP.

nicolas-grekas added a commit that referenced this pull request Aug 2, 2022
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Filesystem] Remove needless `mb_*` calls

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #47137
| License       | MIT
| Doc PR        | None

Issue fixed by adjusting to mb_strrpos to return expected index.

Commits
-------

07242cc [Filesystem] Remove needless `mb_*` calls
This was referenced Aug 26, 2022
@fabpot fabpot mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants