-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Filesystem] Remove needless mb_*
calls
#47155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual fix should be to drop all mb_
prefix in this class as they don't serve any purpose.
Can you please do the change?
Just keep the call to |
I will split off the removal of |
But the original issue is caused by these useless calls to mb_ so this topic cannot be split in two PRs (merging this PR as is doesn't make sense since it only builds on a preexisting mistake). |
As mentioned, mb operations were left in for lowercasing as character lowercasing might differ from internal language lowercasing strategy. |
mb_*
calls
Thank you @HellFirePvP. |
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Filesystem] Remove needless `mb_*` calls | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47137 | License | MIT | Doc PR | None Issue fixed by adjusting to mb_strrpos to return expected index. Commits ------- 07242cc [Filesystem] Remove needless `mb_*` calls
Issue fixed by adjusting to mb_strrpos to return expected index.