Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] [AbstractToken] getUserIdentifier() must return a string #47335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

mpiot
Copy link
Contributor

@mpiot mpiot commented Aug 19, 2022

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Fix the getUserIdentifier() method from Symfony\Component\Security\Core\Authentication\Token\AbstractToken, he method must return a string, but based on a nullable UserInterface object.

@mpiot mpiot requested review from wouterj and chalasr as code owners August 19, 2022 13:02
@carsonbot carsonbot added this to the 6.2 milestone Aug 19, 2022
@carsonbot carsonbot changed the title [Security][AbstractToken] getUserIdentifier() must return a string [Security] [AbstractToken] getUserIdentifier() must return a string Aug 19, 2022
@xabbuh
Copy link
Member

xabbuh commented Aug 19, 2022

Even for the 6.0 branch, right?

@mpiot
Copy link
Contributor Author

mpiot commented Aug 19, 2022

@xabbuh maybe, I've just based it on the version I use

@fabpot fabpot modified the milestones: 6.2, 6.0 Aug 19, 2022
@fabpot fabpot changed the base branch from 6.2 to 6.0 August 19, 2022 13:30
@fabpot fabpot force-pushed the security-abstract-token-user-nullable branch from 7e7ef05 to 2987d58 Compare August 19, 2022 13:30
@fabpot
Copy link
Member

fabpot commented Aug 19, 2022

Good catch, thanks @mpiot.

@fabpot fabpot merged commit c616e2c into symfony:6.0 Aug 19, 2022
This was referenced Aug 26, 2022
@fabpot fabpot mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants