[VarDumper] Ignore \Error in __debugInfo() #48359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc84f11 to
9bb2d67
Compare
|
I don't think we want to ship this change in 4.4's final bugfix release. Let's target 5.4 instead? |
|
Or fix the vendor? |
9bb2d67 to
cc5ab14
Compare
nicolas-grekas
approved these changes
Dec 4, 2022
chalasr
approved these changes
Dec 4, 2022
fabpot
approved these changes
Dec 9, 2022
|
Thank you @fancyweb. |
Merged
This was referenced Dec 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__debugInfo()can throw\TypeError(the test case is from a real vendor doing that 😅)