Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Add Bandwidth bridge #48389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

[Notifier] Add Bandwidth bridge #48389

merged 1 commit into from
Dec 2, 2022

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#17483
Recipe symfony/recipes#1153

This PR add the notifier bridge for Bandwidth (SMS).

@carsonbot carsonbot added this to the 6.3 milestone Nov 29, 2022
@gnito-org gnito-org force-pushed the bandwidth-notifier branch 2 times, most recently from a2106fd to 52807b7 Compare November 29, 2022 20:00
OskarStark
OskarStark reviewed Nov 29, 2022
View reviewed changes
@OskarStark OskarStark mentioned this pull request Nov 30, 2022
Merged
@gnito-org gnito-org force-pushed the bandwidth-notifier branch 7 times, most recently from 0f5277c to 0a1be0f Compare November 30, 2022 11:50
@OskarStark
Copy link
Contributor

One minor and a test change, afterwards ready to merge from my side 👍

@gnito-org
Copy link
Contributor Author

😮‍💨 🤕

This has been an extremely painful exercise. Not conducive to enthusiastic contribution.

RUN AUTOMATED CODE FORMATTING DURING MERGE OR SOMETHING LIKE THAT, if you guys want to enforce a specific code formatting standard. I'm all for it, but don't burden the contributors with it.

@OskarStark
Copy link
Contributor

This has been an extremely painful exercise. Not conducive to enthusiastic contribution.

I am very sorry, we don't have a very hard coding standard, the reason is, that sometimes we allow it. In this case it's more about "keep all the bridges nearly the same", it makes it much easier to maintain. Most of the stuff was copied from another bridge, which is totally fine, but the "code style" was not copied.

In your case it was even harder, because you opened four PRs in parallel 🤷‍♂️

One test is still failing, maybe you can have a look. Thanks

@OskarStark OskarStark requested a review from fabpot November 30, 2022 16:39
@fabpot fabpot force-pushed the bandwidth-notifier branch from 37fb6ca to 604fd9f Compare December 2, 2022 16:03
@fabpot
Copy link
Member

fabpot commented Dec 2, 2022

Thank you @gnito-org.

@fabpot fabpot merged commit 043257f into symfony:6.3 Dec 2, 2022
@gnito-org gnito-org deleted the bandwidth-notifier branch December 3, 2022 00:38
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@gnito-org @OskarStark @fabpot @carsonbot