Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Add getConstraint() method to ConstraintViolationInterface #48671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

syl20b
Copy link
Contributor

@syl20b syl20b commented Dec 15, 2022

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Fix #48626
License MIT
Doc PR

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@syl20b syl20b force-pushed the constraint-violation-interface-add-getconstraint branch from 63ffded to c939002 Compare December 15, 2022 20:57
@carsonbot
Copy link

Hey!

I think @alexandre-daubois has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2022

Ah, we should probably also document this in UPGRADE-6.3.md.

@syl20b syl20b force-pushed the constraint-violation-interface-add-getconstraint branch from c939002 to f690632 Compare December 18, 2022 19:36
@syl20b
Copy link
Contributor Author

syl20b commented Dec 18, 2022

UPGRADE-6.3 updated ;)

@OskarStark OskarStark changed the title [Validator] add the getConstraint() to the ConstraintViolationInterface [Validator] Add getConstraint()method to ConstraintViolationInterface` Dec 18, 2022
@OskarStark OskarStark changed the title [Validator] Add getConstraint()method to ConstraintViolationInterface` [Validator] Add getConstraint() method to ConstraintViolationInterface Dec 18, 2022
@fabpot fabpot force-pushed the constraint-violation-interface-add-getconstraint branch from f690632 to 0118348 Compare December 22, 2022 16:40
@fabpot
Copy link
Member

fabpot commented Dec 22, 2022

Thank you @syl20b.

@fabpot fabpot merged commit 24fdf38 into symfony:6.3 Dec 22, 2022
@syl20b syl20b deleted the constraint-violation-interface-add-getconstraint branch December 22, 2022 16:42
@fabpot fabpot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Validator] add the getConstraint() to the ConstraintViolationInterface
5 participants